Removed impressionist counter cache

README

@@ -0,0 +1,3 @@
+Orbit Announcement
+
+Version 0.0.3

README.rdoc

@@ -1,3 +1,5 @@
 = Announcement
 
-This project rocks and uses MIT-LICENSE.
+This project rocks and uses MIT-LICENSE.
+* Tagging
+* Categories

app/controllers/panel/announcement/api/bulletins_controller.rb

@@ -0,0 +1,83 @@
+# API for Announcement Module
+# 
+# Simple access control
+#   params[:access_token] = Site ID
+#   ex: /panel/announcement/api/bulletins.json?access_token=5301d8be45d5f42f4f000001
+# 
+# Set Language
+#   Language can be "zh_tw" or "en"
+#   ex: /panel/announcement/api/bulletins.json?lang=en&access_token=5301d8be45d5f42f4f000001
+# 
+# Get Categories and Tags
+#   ex: /panel/announcement/api/categories_tags.json&access_token=5301d8be45d5f42f4f000001
+# 
+# Query Bulletins
+#   Set page number use params[:page_num]
+#   Set number of results per page use params[:per_page]
+#   ex: /panel/announcement/api/bulletins.json?page_num=3&per_page=15&access_token=5301d8be45d5f42f4f000001
+# 
+#   Filter bulletins with categories use params[:categories]
+#   ex: /panel/announcement/api/bulletins.json?categories[]=53046e4045d5f462a2000006&access_token=5301d8be45d5f42f4f000001
+# 
+#   Filter bulletins with tags use params[:tags]
+#   ex: /panel/announcement/api/bulletins.json?tags[]=5318e58d45d5f41127000007&access_token=5301d8be45d5f42f4f000001
+# 
+#   Filter bulletins with "is_hot" use params[:is_hot]
+#   ex: /panel/announcement/api/bulletins.json?is_hot=1&access_token=5301d8be45d5f42f4f000001
+#   
+#   Search bulletin title, subtitle, text with params[:keyword]
+#   ex: /panel/announcement/api/bulletins.json?keyword=大學&access_token=5301d8be45d5f42f4f000001
+
+class Panel::Announcement::Api::BulletinsController < OrbitWidgetController
+  before_filter :set_I18n, :check_site_id
+
+  def get_categories_tags
+    module_id = ModuleApp.where(:key=>"announcement").first.id
+    categories = Category.where(:module_app_id => module_id).collect{|c| {"id"=>c.id, "title"=>c.title_translations}}
+    module_tags = ModuleTag.where(:module_app_id => module_id).collect{|t| t.id}
+    tags = Tag.any_of({:tag_lease_id.in => module_tags}).collect{|t| {"id"=>t.id, "title"=>t.name_translations}}
+
+    render :json => {
+      "categories" => categories, 
+      "tags" => tags
+    }
+  end
+
+  def get_bulletins
+    page_num = params[:page_num].blank? ? 0 : params[:page_num].to_i
+    per_page = params[:per_page].blank? ? 10 : params[:per_page].to_i
+    per_page = per_page > 0 ? per_page : 10
+
+    if !params[:keyword].blank?
+      keyword = Regexp.new(".*"+params[:keyword]+".*")
+      bulletins = Bulletin.any_of({:title=>keyword},{:subtitle=>keyword},{:text=>keyword}).available_for_lang(I18n.locale)
+    else
+      bulletins = Bulletin.available_for_lang(I18n.locale)
+    end
+    
+    bulletins = bulletins.where(:is_hot => params[:is_hot]) if !params[:is_hot].blank?
+    bulletins = bulletins.where(:category_id.in => params[:categories]) if !params[:categories].blank?
+    bulletins = bulletins.where(:tagged_ids.in => params[:tags]) if !params[:tags].blank?
+    
+    bulletins = bulletins.desc( :is_top, :postdate).page(page_num).per(per_page)
+
+    total_pages = (bulletins.count / per_page) + 1
+    render :json => {
+      "bulletins" => bulletins,
+      "bulletins_count" => bulletins.count,
+      "page_num" => page_num,
+      "total_pages" => total_pages,
+      "lang"=>I18n.locale
+    }
+  end
+
+  protected
+
+  def set_I18n
+    I18n.locale = params[:lang] if params[:lang].present?
+  end
+
+  def check_site_id
+    raise ActionController::RoutingError.new('Not Found') if Site.first.id.to_s != params['access_token']
+  end
+end

app/controllers/panel/announcement/back_end/approvals_controller.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 class Panel::Announcement::BackEnd::ApprovalsController  < OrbitBackendController
   before_filter :authenticate_user!
   before_filter :is_admin?
@@ -7,7 +6,6 @@ class Panel::Announcement::BackEnd::ApprovalsController  < OrbitBackendControlle
 
   
   def preview_and_approve
-    email_group_data
     @bulletin = Bulletin.find params[:bulletin_id]
   end
   
@@ -17,14 +15,6 @@ class Panel::Announcement::BackEnd::ApprovalsController  < OrbitBackendControlle
     @bulletin.proc_check(params[:bulletin][:is_checked],params[:bulletin][:not_checked_reason])
     @bulletin.de_pending
      if @bulletin.save
-
-        if @bulletin.email_sent == true && @bulletin.is_checked == true && !@bulletin.is_rejected
-          send_email_data(@bulletin)
-
-          @bulletin.email_sent = false
-          @bulletin.save
-        end
-
         notice = t('announcement.approve_bulletin_success')
      else
         notice = t('announcement.approve_bulletin_fail')
@@ -71,68 +61,5 @@ class Panel::Announcement::BackEnd::ApprovalsController  < OrbitBackendControlle
     object_auth.privilege_users = privilege_users
     object_auth
   end
-
-  def send_email_data(bulletin)
-
-    @site = Site.first
-    @user = User.find(bulletin.create_user_id)
-    @host = request.host_with_port
-
-    email_group_data
-
-    @group_mail = Array.new
-
-    bulletin.email_group.each do |egroup|
-
-      if @email_group_data.include?(egroup) and (egroup == 'e_0' or egroup == 'e_1' or egroup == 'e_2' or egroup == 'e_3')
-
-        @group_mail << @email_group_data[egroup]["email"]
-
-      elsif @email_group_data.include?(egroup) and egroup == 'e_4'
-
-        @group_mail <<  bulletin.other_mailaddress 
-
-      end
-
-    end
-
-    if !@group_mail.join.blank?
-
-      @mail_content = {
-        "host" => @host,
-        "site_title" => @site.title,
-        "title" => bulletin.title,
-        "template" => 'announcement_mailer/cron_mail',
-        "url" => "http://#{@host}#{panel_announcement_front_end_bulletin_path(bulletin, :category_id => bulletin.category.id)}"
-      }
-
-      @mail_cron = {  
-        :mail_from_app => 'announcement',
-        :mail_from => @user.email,
-        :mail_reply_to => @user.email,
-        :mail_subject => "#{t("announcement.mail_subject",:site_title => @site.title)}：#{bulletin.title}",
-        :mail_to => @group_mail.join(','),
-        :mail_content => @mail_content ,
-        # :mail_sentdate => bulletin.email_sentdate,
-        :mail_sentdate => DateTime.now,
-        :create_user_id => bulletin.create_user_id,
-        :update_user_id => bulletin.create_user_id
-      } 
-
-      @mail_cron = MailCron.new(@mail_cron) 
-
-      @mail_cron.save
-
-      MailCron.send_mail_now(@mail_cron.id)
-
-    end
-    
-  end
-
-  def email_group_data
-
-    @email_group_data =  Bulletin.email_group_data
-    
-  end
   
 end

app/controllers/panel/announcement/back_end/bulletins_controller.rb

@@ -1,5 +1,4 @@
 # encoding: utf-8
-
 class Panel::Announcement::BackEnd::BulletinsController < OrbitBackendController
   # include OrbitControllerLib::DivisionForDisable
 
@@ -21,8 +20,6 @@ class Panel::Announcement::BackEnd::BulletinsController < OrbitBackendController
 
 
   def index
-    email_group_data
-
     @tags = get_tags
     @categories = get_categories_for_index
     @statuses = get_statuses
@@ -51,11 +48,8 @@ class Panel::Announcement::BackEnd::BulletinsController < OrbitBackendController
   # GET /bulletins/new
   # GET /bulletins/new.xml
   def new
-
-    email_group_data
-
     if(session[:in_validate_object].blank?)
-      @bulletin = Bulletin.new(:postdate => DateTime.now)
+      @bulletin = Bulletin.new(:postdate => DateTime.now, :email_sentdate => DateTime.now)
     else
       @bulletin = session[:in_validate_object]
       session[:in_validate_object] = {}
@@ -71,14 +65,12 @@ class Panel::Announcement::BackEnd::BulletinsController < OrbitBackendController
 
   # GET /bulletins/1/edit
   def edit
-
-    email_group_data
-    
     @bulletin = Bulletin.find(params[:id])
+    @email_users = @bulletin.get_email_users    
     @tags = get_tags
     is_authorized_sub_manager = @bulletin.category.auth_sub_manager.authorized_user_ids rescue nil
 
-    if !(is_manager? || is_admin? || (is_authorized_sub_manager.include?(current_user.id) and @bulletin.create_user_id == current_user.id))
+    if !(is_manager? || is_admin? || is_authorized_sub_manager.include?(current_user.id))
       redirect_to :action => :index
     else
       # @summary_variable = @bulletin.summary_variable
@@ -92,31 +84,33 @@ class Panel::Announcement::BackEnd::BulletinsController < OrbitBackendController
   # POST /bulletins
   # POST /bulletins.xml
   def create
-
-    email_group_data
-    
     @tags = get_tags
+
+    params[:bulletin][:email_user_ids] = params[:bulletin][:email_user_ids].uniq
+    params[:bulletin][:email_user_ids].delete('')
+
     @bulletin = Bulletin.new(params[:bulletin])
     @bulletin.deadline = nil if (@bulletin.deadline < @bulletin.postdate rescue nil)
 
     @bulletin.create_user_id = current_user.id
     @bulletin.update_user_id = current_user.id
-    if(is_manager? || is_admin?)
-      @bulletin.is_checked = true
-      @bulletin.is_rejected = false
-      @bulletin.de_pending
-    end
+    # if(is_manager? || is_admin?)
+    #   @bulletin.is_checked = true
+    #   @bulletin.is_rejected = false
+    #   @bulletin.de_pending
+    # end
 
     respond_to do |format|
       if @bulletin.save
 
-        if @bulletin.email_sent == true && @bulletin.is_checked == true && !@bulletin.is_rejected
+        if @bulletin.email_sent == true && (is_manager? || is_admin?)
           send_email_data(@bulletin)
 
           @bulletin.email_sent = false
           @bulletin.save
         end
 
+
         format.html { redirect_to(panel_announcement_back_end_bulletins_url, :notice => t('announcement.create_bulletin_success')) }
         format.xml  { render :xml => @bulletin, :status => :created, :location => @bulletin }
         # format.js
@@ -141,20 +135,26 @@ class Panel::Announcement::BackEnd::BulletinsController < OrbitBackendController
   # PUT /bulletins/1.xml
 
   def update
+      @bulletin = Bulletin.find(params[:id])
 
-    email_group_data
-  
-    @bulletin = Bulletin.find(params[:id])
+      params[:bulletin][:tag_ids] = (params[:bulletin][:tag_ids] ? params[:bulletin][:tag_ids] : [])
 
-    params[:bulletin][:update_user_id] = current_user.id
+      params[:bulletin][:email_user_ids] = params[:bulletin][:email_user_ids].uniq
+      params[:bulletin][:email_user_ids].delete('')
+
+      params[:bulletin][:update_user_id] = current_user.id
+      
+      delete_out_invalid_date_from_params
+      respond_to do |format|
+        if @bulletin.update_attributes(params[:bulletin])
+
+          if @bulletin.email_sent == true && (is_manager? || is_admin?)
+            send_email_data(@bulletin)
+
+            @bulletin.email_sent = false
+            @bulletin.save
+          end
 
-    delete_out_invalid_date_from_params
-    respond_to do |format|
-      if @bulletin.update_attributes(params[:bulletin])
-        if(is_manager? || is_admin?)
-          @bulletin.is_checked = true
-          @bulletin.is_rejected = false
-          @bulletin.de_pending!
           format.html { redirect_to(panel_announcement_back_end_bulletins_url, :notice => t('bulletin.update_bulletin_success')) }
           format.js  { render 'toggle_enable' }
           format.xml  { head :ok }
@@ -163,27 +163,10 @@ class Panel::Announcement::BackEnd::BulletinsController < OrbitBackendController
           format.html { render :action => "edit" }
           format.xml  { render :xml => @bulletin.errors, :status => :unprocessable_entity }
         end
-
-        if @bulletin.email_sent == true && @bulletin.is_checked == true && !@bulletin.is_rejected
-          send_email_data(@bulletin)
-
-          @bulletin.email_sent = false
-          @bulletin.save
-        end
-
-        format.html { redirect_to(panel_announcement_back_end_bulletins_url, :notice => t('bulletin.update_bulletin_success')) }
-        format.js  { render 'toggle_enable' }
-        format.xml  { head :ok }
-      else
-        @tags = get_tags
-        format.html { render :action => "edit" }
-        format.xml  { render :xml => @bulletin.errors, :status => :unprocessable_entity }
       end
 
     end
 
-  end
-
   # DELETE /bulletins/1
   # DELETE /bulletins/1.xml
   def destroy
@@ -215,28 +198,13 @@ class Panel::Announcement::BackEnd::BulletinsController < OrbitBackendController
     @user = User.find(bulletin.create_user_id)
     @host = request.host_with_port
 
-    email_group_data
-
-    @group_mail = Array.new
-
-    bulletin.email_group.each do |egroup|
-
-      if @email_group_data.include?(egroup) and (egroup == 'e_0' or egroup == 'e_1' or egroup == 'e_2' or egroup == 'e_3')
-
-        @group_mail << @email_group_data[egroup]["email"]
-
-      elsif @email_group_data.include?(egroup) and egroup == 'e_4'
-
-        @group_mail <<  bulletin.other_mailaddress 
-
-      end
-
-    end
-
+    @group_mail = MailCron.get_send_group_mail( bulletin.email_user_ids , bulletin.other_mailaddress )
+    
     if !@group_mail.join.blank?
 
       @mail_content = {
         "host" => @host,
+        "lang" => I18n.locale,
         "site_title" => @site.title,
         "title" => bulletin.title,
         "template" => 'announcement_mailer/cron_mail',
@@ -245,14 +213,12 @@ class Panel::Announcement::BackEnd::BulletinsController < OrbitBackendController
 
       @mail_cron = {  
         :mail_from_app => 'announcement',
-        :mail_from => @user.email,
-        :mail_reply_to => @user.email,
-        :mail_subject => "#{t("announcement.mail_subject")}：",
+        # :mail_from => @user.email,
+        # :mail_reply_to => @user.email,
         :mail_subject => "#{t("announcement.mail_subject",:site_title => @site.title)}：#{bulletin.title}",
         :mail_to => @group_mail.join(','),
         :mail_content => @mail_content ,
-        # :mail_sentdate => bulletin.email_sentdate,
-        :mail_sentdate => DateTime.now,
+        :mail_sentdate => bulletin.email_sentdate,
         :create_user_id => bulletin.create_user_id,
         :update_user_id => bulletin.create_user_id
       } 
@@ -261,17 +227,9 @@ class Panel::Announcement::BackEnd::BulletinsController < OrbitBackendController
 
       @mail_cron.save
 
-      MailCron.send_mail_now(@mail_cron.id)
-
     end
     
-  end
-
-  def email_group_data
-
-    @email_group_data =  Bulletin.email_group_data
-    
-  end
+  end  
 
   def delete_out_invalid_date_from_params
     if((params[:bulletin]["deadline(1i)"] && params[:bulletin]["deadline(1i)"].blank?) or (params[:bulletin]["deadline(2i)"] && params[:bulletin]["deadline(2i)"].blank?) or (params[:bulletin]["deadline(3i)"] && params[:bulletin]["deadline(3i)"].blank?)) 

app/controllers/panel/announcement/front_end/bulletins_controller.rb

@@ -12,8 +12,13 @@ class Panel::Announcement::FrontEnd::BulletinsController < OrbitWidgetController
     if params[:search_query] == ""
       @bulletins = get_bulletins_for_index
     else
-      @search = Bulletin.tire.search "#{params[:search_query]}"
-      search_result = @search.collect{|result| result.id}
+      key_string = params[:search_query]
+      keywords = key_string.split(/\s+(?=(?:[^"]*"[^"]*")*[^"]*$)/)
+      regex = Regexp.union(keywords.map{|word| Regexp.new(".*"+word+".*", "i")})
+
+      query = ["title","subtitle","text"].map{|f| {f.to_sym => regex} }
+      res = Bulletin.any_of(query)
+      search_result = res.collect{|result| result.id}
 
       @bulletins = Bulletin.all.available_for_lang(I18n.locale).can_display.any_in(_id:search_result).page( params[:page_main]).per(@page_num)
     end

app/models/bulletin.rb

@@ -13,10 +13,10 @@ class Bulletin
   include OrbitModel::TimeFrame
   include OrbitTag::Taggable
 
-  include Tire::Model::Search
-  include Tire::Model::Callbacks
+  # include Tire::Model::Search
+  # include Tire::Model::Callbacks
 
-  is_impressionable :counter_cache => { :column_name => :view_count }
+  is_impressionable
 
   field :title, localize: true
   field :subtitle, localize: true
@@ -25,25 +25,14 @@ class Bulletin
   field :create_user_id
   field :update_user_id, :class_name => "User"
   
-  field :is_top, :type => Boolean, :default => false
-  field :is_hot, :type => Boolean, :default => false
-  field :is_hidden, :type => Boolean, :default => false
-  field :is_checked, :type => Boolean, :default => false
-  field :is_pending, :type => Boolean, :default => true 
-  field :is_rejected, :type => Boolean, :default => false 
   field :view_count, :type => Integer, :default => 0
   
-  field :not_checked_reason
-  
   field :public, :type => Boolean, :default => true
 
   field :email_sent, :type => Boolean, :default => false
   field :email_sentdate , :type => DateTime
-  field :email_group, :type => Array
+  field :email_user_ids
   field :other_mailaddress
-  
-  scope :can_display, where(is_checked: true, is_rejected: false, is_pending: false)
-  scope :available_for_lang, ->(locale){ where("available_for_#{locale}".to_sym => true) }
 
   mount_uploader :image, ImageUploader
 
@@ -55,9 +44,9 @@ class Bulletin
   
   validates :title, :at_least_one => true
 
-  def to_indexed_json
-    self.to_json
-  end
+  # def to_indexed_json
+  #   self.to_json
+  # end
 
   # search_in :title, :subtitle, :text
 
@@ -77,11 +66,6 @@ class Bulletin
   def bulletin_category_with_title
     self.category.title
   end
-  
-  def bulletin_create_dept
-    unit_field = User.get_member_list_attribute_field("staff","Unit") 
-    User.get_member_list_attribute_value(self.create_user_id,unit_field.id).get_value_by_locale(I18n.locale)  rescue nil
-  end
 
   def get_bulletin_category
     self.category
@@ -130,37 +114,6 @@ class Bulletin
    
   end
 
-  def proc_check(check,not_pass_info = "")
-    self.is_checked = true
-      if check =="true"
-        self.is_rejected = false
-      elsif check == "false"
-        self.is_rejected = true
-        self.not_checked_reason = not_pass_info
-      end
-  end
-
-  def de_pending
-    self.is_pending = false
-  end
-
-  def de_pending!
-    de_pending
-    self.save!
-  end
-
-  def is_checked?
-    !self.is_pending && self.is_checked && (self.is_rejected == false)
-  end
-  
-  def is_pending?
-    self.is_pending
-  end
-  
-  def is_rejected?
-    !self.is_pending && self.is_rejected && (self.is_rejected == true)
-  end 
-
   
   def save_bulletin_links
 	self.bulletin_links.each do |t|
@@ -201,47 +154,16 @@ class Bulletin
     preview_object
   end
 
-  def get_email_group_data(email_group_data)
-
-    group_mail = Array.new
-
-    self.email_group.each do |egroup|
-
-      if email_group_data.include?(egroup) and (egroup == 'e_0' or egroup == 'e_1' or egroup == 'e_2' or egroup == 'e_3')
-
-        group_mail << "#{email_group_data[egroup]["email"]}(#{email_group_data[egroup]["name"]})"
-
-      elsif email_group_data.include?(egroup) and egroup == 'e_4'
-
-        self.other_mailaddress.split(",").each do |otmail|
-
-          group_mail <<  "#{otmail}(#{email_group_data[egroup]["name"]})" 
-
-        end
-
-      end
-
-    end
-
-    group_mail.join("<br />").html_safe
-
+  def get_email_users
+    User.find(self.email_user_ids) rescue []
   end
 
+  def view_count
+    Impression.where(:impressionable_id=>self.id).count
+  end
 
   protected
 
-  def self.email_group_data
-
-    @email_group_data = { 
-      'e_0'=> {"name"=>I18n.t('announcement.email_group_data_0'), "email"=>"alluser@tea.ntue.edu.tw"}, 
-      'e_1'=> {"name"=>I18n.t('announcement.email_group_data_1'), "email"=>"allstu@tea.ntue.edu.tw"}, 
-      'e_2'=> {"name"=>I18n.t('announcement.email_group_data_2'), "email"=>"allgrad@tea.ntue.edu.tw"}, 
-      'e_3'=> {"name"=>I18n.t('announcement.email_group_data_3'), "email"=>"allad@tea.ntue.edu.tw"}, 
-      'e_4'=> {"name"=>I18n.t('announcement.email_group_data_4')}
-    }
-    
-  end
-
   # def clean_values
   #   self.bulletin_links.each do |link|
   #     link.delete if link.url.blank? && link.title.blank?

app/views/announcement_mailer/cron_mail.html.erb

@@ -1,4 +1,7 @@
 <% # encoding: utf-8 %>
+
+<% I18n.locale = @data.mail_content["lang"] %>
+
 <!DOCTYPE html>
 <html>
   <head>

app/views/panel/announcement/back_end/approvals/_modal_approve.html.erb

@@ -5,18 +5,8 @@
     <a class="close" data-dismiss="modal">×</a>
     <h3><%= t(:preview) %></h3>
   </div>
-  <div class="modal-body clearfix">
-    <div class="modal-left">
-    	
-		<% if !@bulletin.email_group.blank? %>
-			<%= label_tag 'group_mail' %>
-			<%= @bulletin.get_email_group_data(@email_group_data) %>
-		<% end %>
-		
-    </div>
-    <div class="modal-right">
+  <div class="modal-body">
 		<iframe src=<%= panel_announcement_front_end_bulletin_path(bulletin, :category_id => bulletin.category.id ,:preview=>true) %>></iframe>
-	</div>
   </div>
   <div class="modal-footer">
 

app/views/panel/announcement/back_end/bulletins/_form.html.erb

@@ -9,7 +9,8 @@
   <%= javascript_include_tag "lib/datetimepicker/datetimepicker.js" %>
   <%= javascript_include_tag "lib/modal-preview" %>
   <%= javascript_include_tag "lib/file-type" %>
-  <%= javascript_include_tag "lib/module-area" %>
+  <%= javascript_include_tag "lib/module-area" %>  
+  <%= javascript_include_tag "member-selection" %>
 <% end %>
 
 <%= f.error_messages %>
@@ -36,7 +37,7 @@
     </li>
     <li>
       <a href="#mail-group" data-toggle="tab"><%= t('announcement.email_reminder')%></a>
-    </li>
+    </li>    
   </ul>
 
   <!-- Module -->
@@ -103,7 +104,6 @@
           <% @tags.each do |tag| %>
             <label class="checkbox inline btn <%= 'active' if @bulletin.tag_ids.include?(tag.id) %>">
               <%= check_box_tag 'bulletin[tag_ids][]', tag.id, @bulletin.tag_ids.include?(tag.id) %> <%= tag.name %>
-              <%= hidden_field_tag 'bulletin[tag_ids][]', '' %>
             </label>
           <% end %>
         </div>
@@ -123,7 +123,7 @@
               <% if @bulletin.image.file %>
                 <%= image_tag @bulletin.image %>
               <% else %>
-                <img src="http://www.placehold.it/290x230/EFEFEF/AAAAAA" />
+                <img src="http://www.placehold.it/50x50/EFEFEF/AAAAAA" />
               <% end %>
             </div>
             <div class="fileupload-preview fileupload-exists thumbnail pull-left"></div>
@@ -138,15 +138,8 @@
                 <%= f.check_box :remove_image %><%= t(:remove) %>
               </label>
             </div>
-            <br />
-            <span>
-            <%= t("ad.widget_info_for_ad_image_size", :best_size=> "290px(w) x 230px(h)") %>
-            <br />
-            <%= t("announcement.image_upload_size_note", :image_upload_size =>'900kb') %>
-            <br />
-            <%= t("announcement.image_note")%>
-            </span>
           </div>
+          <div class="image_note"><%= t("announcement.image_note")%></div>
         </div>
       </div>
 
@@ -157,24 +150,17 @@
 
       <!-- Mail Group -->
       <div class="control-group">
-        <label class="control-label muted"><%= t("announcement.email_group") %></label>
+        <label class="control-label muted"><%= t("announcement.email_to") %></label>
         <div class="controls">
 
           <label class="checkbox inline">
-            <%= check_box_tag('bulletin[email_sent]', '1', (!@bulletin.email_sent.blank? ? true : false), :id=>'remind-check') %><%= t('announcement.activate_email_eminder')%>
+            <%= check_box_tag('bulletin[email_sent]', '1', (!@bulletin.email_sent.blank? ? true : false), :id=>'remind-check') %><%= t('announcement.activate_email_reminder')%>
           </label>
 
           <div class="content-box">
-
-            <% @email_group_data.collect do |k,v| %>
-
-            <label class="checkbox inline">
-              <%= check_box_tag 'bulletin[email_group][]', k, (@bulletin.email_group.nil? ?  false : @bulletin.email_group.include?(k)), :id => "field-#{k}" %> <%= v["name"] %>
-              <%= hidden_field_tag 'bulletin[email_group][]', '' %>
-            </label>
-
-            <% end if !@email_group_data.blank? %>
-
+            <p>
+            <%= render partial: 'admin/member_selects/email_selection_box', locals: {field: 'bulletin[email_user_ids][]', users: @email_users} %>
+            </p>
           </div>
         </div>
       </div>
@@ -186,6 +172,15 @@
             <%= f.text_area :other_mailaddress, :class=>"span12", :cols=>"25", :rows=>"10" %>
           </div>
         </div>
+      </div> 
+
+      <div class="content-box">
+      <div class="control-group">
+        <label class="control-label muted"><%= t("announcement.email_sentdate") %></label>
+        <div class="controls">
+          <%= f.datetime_picker :email_sentdate, :no_label => true %>
+        </div>
+      </div>
       </div>
 
     </div>
@@ -360,6 +355,7 @@
       $('#remind-check').on('change', function() {
           $(this).prop('checked') ? $('.content-box').removeClass('hide'):$('.content-box').addClass('hide')
       })
+
     });
   </script>
 <% end %>

app/views/panel/announcement/back_end/bulletins/index.html.erb

@@ -6,9 +6,9 @@
 	quick_edit_link type: 'delete',
 									link: 'panel_announcement_back_end_bulletin_path'
 									# can have: title, warning, cancel and submit values
-	quick_edit_link type: 'approval',
-									link: 'panel_announcement_back_end_bulletin_approval_preview_path'
-	quick_edit_link type: 'reject_reason'
+	# quick_edit_link type: 'approval',
+	# 								link: 'panel_announcement_back_end_bulletin_approval_preview_path'
+	# quick_edit_link type: 'reject_reason'
 	field type: 'status',
 				db_field: @statuses,
 				translation: 'status',
@@ -37,6 +37,11 @@
 	field type: 'tags',
 				hide: 'all',
 				sort: 'tags'
+	field db_field: 'email_user_ids',
+				hide: 'all',
+				translation: 'announcement.email_to',
+				display_option: '"<br />#{MailCron.get_send_group_mail(object.email_user_ids , object.other_mailaddress).join("， ").html_safe}"',
+				sort: 'email_user_ids'
 	field type: 'id',
 				db_field: 'update_user_id',
 				model: User,

app/views/panel/announcement/front_end/bulletins/show.html.erb

@@ -4,11 +4,8 @@
 	<div class="info1">
 		<span class="pull-right"><%= dislpay_view_count(@bulletin) %></span>
 		<span class="date"><%= display_date_time(@bulletin.postdate) %></span>
-		<% 
-			unit_field = User.get_member_list_attribute_field("staff","Unit") 
-			unit = User.get_member_list_attribute_value(@bulletin.create_user_id,unit_field.id).get_value_by_locale(I18n.locale)  rescue nil
-		%>
-		<span><%= t('announcement.default_widget.bulletin_create_dept') + ": " + unit unless unit.blank? %></span>
+		<% unit =  @bulletin.cache_dept[I18n.locale.to_s] rescue nil %>
+		<span><%=  link_to unit,panel_announcement_front_end_index_bulletins_by_unit_path(:name=>unit) unless unit.blank? %></span>
 	</div>
 </div>
 <div class="news_paragraph">
@@ -37,4 +34,4 @@
 	<% end %>
 </div>
 
-<%= share_links(@bulletin, 'announcement') %>
+<%= share_links(@bulletin, 'announcement') %>

config/locales/en.yml

@@ -18,7 +18,6 @@ en:
       postdate: Post Date
       subtitle: Subtitle
       title: Title
-      bulletin_create_dept: Unit
     editing_announcement: Edit Announcement
     editing_announcement_category: Edit Category
     file: Attachment
@@ -41,16 +40,10 @@ en:
       index: Index
       search: Search
     email_reminder: Email Reminder
-    activate_email_eminder: Activate Email Reminder
+    activate_email_reminder: Activate Email Reminder
     email_sentdate: Email Time
-    email_group: Email Group
-    email_group_data_0: All Faculty
-    email_group_data_1: Undergraduates
-    email_group_data_2: Postgraduates
-    email_group_data_3: Continuing Ed. Postgraduates 
-    email_group_data_4: Other
-    # mail_subject: this is an announcement reminder from【%{site_title}】
-    mail_subject: 【北教大公告提醒】
+    email_to: Email To
+    mail_subject: this is an announcement reminder from【%{site_title}】
     other_mailaddress: Other Email
     other_mailaddress_note: Divide different email accounts with ","
     mail_hi: Hi

config/locales/zh_tw.yml

@@ -18,7 +18,6 @@ zh_tw:
       postdate: 張貼日期
       subtitle: 副標題
       title: 標題
-      bulletin_create_dept: 單位
     editing_announcement: 編輯類別
     editing_announcement_category: 編輯類別
     error:
@@ -44,18 +43,12 @@ zh_tw:
       search: 搜尋
     more: 更多+
     email_reminder: 寄送提醒
-    activate_email_eminder: 開啟寄送提醒
+    activate_email_reminder: 開啟寄送提醒
     email_sentdate: 寄送時間
-    email_group: 寄送群組
+    email_to: 寄送對象
     other_mailaddress: 其他Mail
     other_mailaddress_note: 輸入多組mail時,請用","逗號隔開
-    email_group_data_0: 全校教職員
-    email_group_data_1: 大學部學生
-    email_group_data_2: 日間部研究生
-    email_group_data_3: 進修部研究生
-    email_group_data_4: 其他
-    # mail_subject: 來自【%{site_title}】的公告事件提醒
-    mail_subject: 【北教大公告提醒】
+    mail_subject: 來自【%{site_title}】的公告事件提醒
     mail_hi: 您好
     mail_url_view: 此封信件為公告事件提醒，請點選以下連結詳細觀看
     mail_source: 來源

config/routes.rb

@@ -41,6 +41,10 @@ Rails.application.routes.draw do
         match "bulletins_side_bar" => "bulletins#bulletins_side_bar"
         match "bulletins_search_block" => "bulletins#bulletins_search_block"
       end
+      namespace :api do
+        get "categories_tags.json" => "bulletins#get_categories_tags"
+        get "bulletins.json" => "bulletins#get_bulletins"
+      end
     end
   end
 end

lib/announcement.rb

@@ -28,20 +28,19 @@ module Announcement
 			data_count 1..10
 
 			authorizable
-			approvable
+			# approvable
 			categorizable
 			taggable
 
 			widgets do
 			  default_widget do
-			    query 'Bulletin.can_display.available_for_lang(I18n.locale).any_of( {deadline: nil,:postdate.lte => Time.now} , {:deadline.gte => Time.now,:postdate.lte => Time.now} )'
+			    query 'Bulletin'
 			    enable ["typeA", "typeB_style3", "typeC"]
 			    image :image
 			    field :postdate
 			    link_field :title,{:method => 'panel_announcement_front_end_bulletin_path',:args=>:self}
 			    link_field :bulletin_category_with_title,{:method => 'panel_announcement_front_end_bulletins_path',:args=>{:category_id => [:category,:id]}}
-		        link_field :subtitle,{:method => 'panel_announcement_front_end_bulletin_path',:args=>:self,:preview=>true}
-		        field :bulletin_create_dept
+			    field :subtitle
 			    link_to_more 'panel_announcement_front_end_bulletins_path',:title_i18n=> 'more_plus'
 			  end