Fix long project name display in issue list and in related dropdown (#23653)
This PR is to fix the second problem mentioned in #23625, along with the
long texts problem in `issue-item-bottom-row` of `issuelist.tmpl`
Main changes are:
1. Add `max-width` to the search dropdowns in issue list and make the
possible long texts inside to show ellipsis if texts are long
2. Adjust the conditions in
[issuelist.tmpl](1d35fa0e78/templates/shared/issuelist.tmpl (L146-L167))
to fix the problem as mentioned by the
[comment](https://github.com/go-gitea/gitea/issues/23625#issuecomment-1479281060)
3. Use `word-break: break-word;` in `issue-item-bottom-row` to break the
possible long texts.
After the PR
issuelist in repo (similar for pr list):
<img width="366" alt="截屏2023-03-23 17 42 40"
src="https://user-images.githubusercontent.com/17645053/227163953-93e9adbd-5785-4c16-b538-9db901787775.png">
dropdowns with long name (Here take reference from github to deal with
the long names cases: show ellipsis with no title, because all these
options are clickable, and it might not be necessary to add titles to
them ):
<img width="370" alt="截屏2023-03-23 17 43 50"
src="https://user-images.githubusercontent.com/17645053/227164215-df6fcaaa-9fee-4256-a57c-053fbcffafbb.png">
<img width="365" alt="截屏2023-03-23 17 43 56"
src="https://user-images.githubusercontent.com/17645053/227164227-9c99abcd-f410-4e07-b5b8-cbce764eedcd.png">
issue page (similar for pr page):
<img width="374" alt="截屏2023-03-23 17 45 37"
src="https://user-images.githubusercontent.com/17645053/227164668-654a8188-dac8-4bbf-a6e3-f3768a644a1b.png">
on PC:
<img width="1412" alt="截屏2023-03-23 17 47 20"
src="https://user-images.githubusercontent.com/17645053/227166694-e7bcc6e5-9667-4cef-9fbf-db85640a2c6c.png">
<img width="1433" alt="截屏2023-03-23 17 46 40"
src="https://user-images.githubusercontent.com/17645053/227165182-4e2a5d19-74bc-4c66-b73c-23cbca176ffe.png">
			
			
This commit is contained in:
		
							parent
							
								
									84daddc2fa
								
							
						
					
					
						commit
						a9cceb0597
					
				|  | @ -99,8 +99,8 @@ | ||||||
| 									{{.locale.Tr "repo.issues.new.open_projects"}} | 									{{.locale.Tr "repo.issues.new.open_projects"}} | ||||||
| 								</div> | 								</div> | ||||||
| 								{{range .OpenProjects}} | 								{{range .OpenProjects}} | ||||||
| 									<a class="{{if $.ProjectID}}{{if eq $.ProjectID .ID}}active selected{{end}}{{end}} item" href="{{$.Link}}?type={{$.ViewType}}&sort={{$.SortType}}&state={{$.State}}&labels={{$.SelectLabels}}&milestone={{$.MilestoneID}}&project={{.ID}}&assignee={{$.AssigneeID}}&poster={{$.PosterID}}"> | 									<a class="{{if $.ProjectID}}{{if eq $.ProjectID .ID}}active selected{{end}}{{end}} item gt-df" href="{{$.Link}}?type={{$.ViewType}}&sort={{$.SortType}}&state={{$.State}}&labels={{$.SelectLabels}}&milestone={{$.MilestoneID}}&project={{.ID}}&assignee={{$.AssigneeID}}&poster={{$.PosterID}}"> | ||||||
| 										{{svg .IconName 18 "gt-mr-3"}}{{.Title}} | 										{{svg .IconName 18 "gt-mr-3 gt-shrink-0"}}<span class="gt-ellipsis">{{.Title}}</span> | ||||||
| 									</a> | 									</a> | ||||||
| 								{{end}} | 								{{end}} | ||||||
| 							{{end}} | 							{{end}} | ||||||
|  | @ -131,7 +131,7 @@ | ||||||
| 							</div> | 							</div> | ||||||
| 							<a class="item" href="{{$.Link}}?q={{$.Keyword}}&type={{$.ViewType}}&sort={{$.SortType}}&state={{$.State}}&labels={{.SelectLabels}}&milestone={{$.MilestoneID}}&project={{$.ProjectID}}&assignee={{$.AssigneeID}}">{{.locale.Tr "repo.issues.filter_poster_no_select"}}</a> | 							<a class="item" href="{{$.Link}}?q={{$.Keyword}}&type={{$.ViewType}}&sort={{$.SortType}}&state={{$.State}}&labels={{.SelectLabels}}&milestone={{$.MilestoneID}}&project={{$.ProjectID}}&assignee={{$.AssigneeID}}">{{.locale.Tr "repo.issues.filter_poster_no_select"}}</a> | ||||||
| 							{{range .Posters}} | 							{{range .Posters}} | ||||||
| 								<a class="{{if eq $.PosterID .ID}}active selected{{end}} item" href="{{$.Link}}?type={{$.ViewType}}&sort={{$.SortType}}&state={{$.State}}&labels={{$.SelectLabels}}&milestone={{$.MilestoneID}}&project={{$.ProjectID}}&assignee={{$.AssigneeID}}&poster={{.ID}}"> | 								<a class="{{if eq $.PosterID .ID}}active selected{{end}} item gt-df" href="{{$.Link}}?type={{$.ViewType}}&sort={{$.SortType}}&state={{$.State}}&labels={{$.SelectLabels}}&milestone={{$.MilestoneID}}&project={{$.ProjectID}}&assignee={{$.AssigneeID}}&poster={{.ID}}"> | ||||||
| 									{{avatar $.Context .}}{{template "repo/search_name" .}} | 									{{avatar $.Context .}}{{template "repo/search_name" .}} | ||||||
| 								</a> | 								</a> | ||||||
| 							{{end}} | 							{{end}} | ||||||
|  | @ -151,7 +151,7 @@ | ||||||
| 							</div> | 							</div> | ||||||
| 							<a class="item" href="{{$.Link}}?q={{$.Keyword}}&type={{$.ViewType}}&sort={{$.SortType}}&state={{$.State}}&labels={{.SelectLabels}}&milestone={{$.MilestoneID}}&project={{$.ProjectID}}&poster={{$.PosterID}}">{{.locale.Tr "repo.issues.filter_assginee_no_select"}}</a> | 							<a class="item" href="{{$.Link}}?q={{$.Keyword}}&type={{$.ViewType}}&sort={{$.SortType}}&state={{$.State}}&labels={{.SelectLabels}}&milestone={{$.MilestoneID}}&project={{$.ProjectID}}&poster={{$.PosterID}}">{{.locale.Tr "repo.issues.filter_assginee_no_select"}}</a> | ||||||
| 							{{range .Assignees}} | 							{{range .Assignees}} | ||||||
| 								<a class="{{if eq $.AssigneeID .ID}}active selected{{end}} item" href="{{$.Link}}?type={{$.ViewType}}&sort={{$.SortType}}&state={{$.State}}&labels={{$.SelectLabels}}&milestone={{$.MilestoneID}}&project={{$.ProjectID}}&assignee={{.ID}}&poster={{$.PosterID}}"> | 								<a class="{{if eq $.AssigneeID .ID}}active selected{{end}} item gt-df" href="{{$.Link}}?type={{$.ViewType}}&sort={{$.SortType}}&state={{$.State}}&labels={{$.SelectLabels}}&milestone={{$.MilestoneID}}&project={{$.ProjectID}}&assignee={{.ID}}&poster={{$.PosterID}}"> | ||||||
| 									{{avatar $.Context .}}{{template "repo/search_name" .}} | 									{{avatar $.Context .}}{{template "repo/search_name" .}} | ||||||
| 								</a> | 								</a> | ||||||
| 							{{end}} | 							{{end}} | ||||||
|  |  | ||||||
|  | @ -1 +1 @@ | ||||||
| {{.Name}}{{if IsShowFullName}}<span class="search-fullname"> {{.FullName}}</span>{{end}} | <span class="gt-ellipsis">{{.Name}}{{if IsShowFullName}}<span class="search-fullname"> {{.FullName}}</span>{{end}}</span> | ||||||
|  |  | ||||||
|  | @ -143,13 +143,15 @@ | ||||||
| 					{{end}} | 					{{end}} | ||||||
| 				</div> | 				</div> | ||||||
| 			</div> | 			</div> | ||||||
|  | 			{{if or .TotalTrackedTime .Assignees .NumComments}} | ||||||
| 			<div class="issue-item-icons-right gt-df gt-p-2"> | 			<div class="issue-item-icons-right gt-df gt-p-2"> | ||||||
| 				<div class="issue-item-icon-right text grey"> |  | ||||||
| 				{{if .TotalTrackedTime}} | 				{{if .TotalTrackedTime}} | ||||||
|  | 				<div class="issue-item-icon-right text grey"> | ||||||
| 						{{svg "octicon-clock" 16 "gt-mr-2"}} | 						{{svg "octicon-clock" 16 "gt-mr-2"}} | ||||||
| 						{{.TotalTrackedTime | Sec2Time}} | 						{{.TotalTrackedTime | Sec2Time}} | ||||||
| 					{{end}} |  | ||||||
| 				</div> | 				</div> | ||||||
|  | 				{{end}} | ||||||
|  | 				{{if .Assignees}} | ||||||
| 				<div class="issue-item-icon-right text grey"> | 				<div class="issue-item-icon-right text grey"> | ||||||
| 					{{range .Assignees}} | 					{{range .Assignees}} | ||||||
| 						<a class="ui assignee tooltip gt-tdn" href="{{.HomeLink}}" data-content="{{.GetDisplayName}}" data-position="left center"> | 						<a class="ui assignee tooltip gt-tdn" href="{{.HomeLink}}" data-content="{{.GetDisplayName}}" data-position="left center"> | ||||||
|  | @ -157,14 +159,16 @@ | ||||||
| 						</a> | 						</a> | ||||||
| 					{{end}} | 					{{end}} | ||||||
| 				</div> | 				</div> | ||||||
| 				<div class="issue-item-icon-right text grey"> | 				{{end}} | ||||||
| 				{{if .NumComments}} | 				{{if .NumComments}} | ||||||
|  | 				<div class="issue-item-icon-right text grey"> | ||||||
| 					<a class="gt-tdn muted" href="{{if .Link}}{{.Link}}{{else}}{{$.Link}}/{{.Index}}{{end}}"> | 					<a class="gt-tdn muted" href="{{if .Link}}{{.Link}}{{else}}{{$.Link}}/{{.Index}}{{end}}"> | ||||||
| 						{{svg "octicon-comment" 16 "gt-mr-2"}}{{.NumComments}} | 						{{svg "octicon-comment" 16 "gt-mr-2"}}{{.NumComments}} | ||||||
| 					</a> | 					</a> | ||||||
|  | 				</div> | ||||||
| 				{{end}} | 				{{end}} | ||||||
| 			</div> | 			</div> | ||||||
| 			</div> | 			{{end}} | ||||||
| 		</li> | 		</li> | ||||||
| 	{{end}} | 	{{end}} | ||||||
| 	{{if .IssueIndexerUnavailable}} | 	{{if .IssueIndexerUnavailable}} | ||||||
|  |  | ||||||
|  | @ -197,6 +197,7 @@ | ||||||
| 
 | 
 | ||||||
| .gt-content-center { align-content: center !important; } | .gt-content-center { align-content: center !important; } | ||||||
| 
 | 
 | ||||||
|  | .gt-shrink-0 { flex-shrink: 0 !important; } | ||||||
| .gt-whitespace-nowrap { white-space: nowrap !important; } | .gt-whitespace-nowrap { white-space: nowrap !important; } | ||||||
| 
 | 
 | ||||||
| @media (max-width: 767px) { | @media (max-width: 767px) { | ||||||
|  |  | ||||||
|  | @ -143,7 +143,8 @@ | ||||||
| 
 | 
 | ||||||
| .repository .filter.menu .menu { | .repository .filter.menu .menu { | ||||||
|   max-height: 500px; |   max-height: 500px; | ||||||
|   overflow-x: auto; |   max-width: 300px; | ||||||
|  |   overflow-x: hidden; | ||||||
|   right: 0 !important; |   right: 0 !important; | ||||||
|   left: auto !important; |   left: auto !important; | ||||||
| } | } | ||||||
|  |  | ||||||
|  | @ -84,6 +84,7 @@ | ||||||
| 
 | 
 | ||||||
| .issue.list > .item .desc a { | .issue.list > .item .desc a { | ||||||
|   color: inherit; |   color: inherit; | ||||||
|  |   word-break: break-word; | ||||||
| } | } | ||||||
| 
 | 
 | ||||||
| .issue.list > .item .desc .time-since, | .issue.list > .item .desc .time-since, | ||||||
|  |  | ||||||
		Loading…
	
		Reference in New Issue